Feat: Add pagination to position history endpoint #401
Conversation
|
Ahh the good old failing tests. Will have to refactor them for the modified changes. I will take some time for those. |
|
Some guidance on how I should approach for the tests to pass will be appreciated. I am still a bit ambiguous on how I should tackle the test cases. I can try to modify the functions so they integrate well the existing test cases, or refactor the test cases to accommodate the functional changes? Please tell me which route would be a better option. |
web_app/api/position.py
Outdated
|
|
||
| positions = position_db_connector.get_positions_by_wallet_id(wallet_id) | ||
|
|
||
| if start is not None: |
There was a problem hiding this comment.
if start is not None:
start_index = max(0, start)
else:
start_index = 0
this all code can be done in one line:
start_index = start and max(0, start) or 0
|
@KeneePatel Any updates, |
|
@KeneePatel Any updates? Just friendly reminder that if you don't update PR you can be unassigned |
|
It was busy today. I will update the PR in 6 hours. |
|
@KeneePatel okay, thank you for update |
Changes include:
get_user_positionsfunction endpoint now has an optionalstartargument for accepting query parameter ofstartget_positions_by_wallet_iddb function now acceptsstart, andlimitparameters to accommodate the changeNo breaking changes
Modification to a functionality is done and was to be expected due to the nature of issue.