Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stake page UI desktop/mobile #400

Merged

Conversation

ONEONUORA
Copy link
Contributor

No description provided.

@whateverfw whateverfw self-requested a review December 17, 2024 21:38
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like there are already existing background file.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use existing background file, delete this

frontend/src/pages/vault/stake/stake.css Show resolved Hide resolved
frontend/src/pages/vault/stake/stake.css Show resolved Hide resolved
frontend/src/pages/vault/vaultLayout.css Show resolved Hide resolved
frontend/src/pages/vault/stake/stake.css Show resolved Hide resolved
@whateverfw whateverfw linked an issue Dec 17, 2024 that may be closed by this pull request
@ONEONUORA
Copy link
Contributor Author

Okay working on it

Copy link
Collaborator

@whateverfw whateverfw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything seems to be OK now, with deskop and mobile, please fix tablet:

image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use existing background file, delete this

@ONEONUORA
Copy link
Contributor Author

Pls can you point to right image name

@whateverfw
Copy link
Collaborator

@ONEONUORA

Pls can you point to right image name

https://github.com/djeck1432/spotnet/blob/main/frontend/public/background.png
it was already used on this page

@whateverfw
Copy link
Collaborator

@ONEONUORA any updates?

@ONEONUORA
Copy link
Contributor Author

ONEONUORA commented Dec 18, 2024

@whateverfw Pls i need more time, I am refactoring the code to fix the tablet view

@ONEONUORA ONEONUORA requested a review from whateverfw December 18, 2024 22:24
Copy link
Collaborator

@whateverfw whateverfw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@djeck1432 djeck1432 self-requested a review December 19, 2024 09:09
Copy link
Owner

@djeck1432 djeck1432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@djeck1432 djeck1432 merged commit 346a6d1 into djeck1432:main Dec 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Frontend] Fix Stake page UI [desktop/mobile]
3 participants