Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add withdraw all contract #384

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Conversation

Judah04
Copy link
Contributor

@Judah04 Judah04 commented Dec 16, 2024

Closes #349

@djeck1432 djeck1432 self-requested a review December 16, 2024 08:44
web_app/api/user.py Outdated Show resolved Hide resolved
web_app/contract_tools/blockchain_call.py Show resolved Hide resolved
web_app/contract_tools/blockchain_call.py Outdated Show resolved Hide resolved
Copy link
Owner

@djeck1432 djeck1432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any updates?

Copy link
Owner

@djeck1432 djeck1432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is last code review.

web_app/contract_tools/blockchain_call.py Outdated Show resolved Hide resolved
web_app/contract_tools/blockchain_call.py Show resolved Hide resolved
:return: detail: "Successfully initiated withdrawals for all tokens"
"""
# Get user's contract address
contract_address = await get_user_contract(wallet_id)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here you can get method get_user_contract to get contract_address, instead of using
user_db.get_contract_address_by_wallet_id

web_app/api/user.py Outdated Show resolved Hide resolved
@djeck1432
Copy link
Owner

@Judah04 Please, sync with main branch

@djeck1432 djeck1432 merged commit 56f9612 into djeck1432:main Dec 17, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Backend] Add new contract call to withdraw all
2 participants