Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stake page ui fix #382

Closed
wants to merge 3 commits into from
Closed

fix: stake page ui fix #382

wants to merge 3 commits into from
+1,940 −1,616

Conversation

canhamzacode
Copy link

No description provided.

@whateverfw whateverfw linked an issue Dec 15, 2024 that may be closed by this pull request
[Frontend] Fix Stake page UI [desktop/mobile] #375
Closed
@whateverfw whateverfw self-requested a review December 15, 2024 10:58
whateverfw
whateverfw requested changes Dec 15, 2024
View reviewed changes
frontend/src/pages/vault/stake/Stake.jsx Show resolved Hide resolved
frontend/src/pages/vault/stake/stake.css Outdated Show resolved Hide resolved
frontend/src/pages/vault/stake/stake.css Outdated Show resolved Hide resolved
frontend/src/pages/vault/stake/stake.css
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sidebar is broken and do not stick to the top when scrolled

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of my change is meant to affect the sidebar. noticed that but i didnt touch it

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sidebar is a part of a page, please fix it.

frontend/src/pages/vault/stake/stake.css
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

table and mobile pages are completely broken, overflowed by a sidebar, did you even test it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes i did. but that was not because of my implementation. Mine was just to update the ui to fit the figma. I believe a seperate issue can be created for that

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's correct, ui should fit the figma. This is UI:
image

and this is Figma:
image

Please, fix it

frontend/src/components/StakeCard/metricCard.css Show resolved Hide resolved
frontend/src/components/StakeCard/metricCard.css Outdated Show resolved Hide resolved
frontend/src/components/StakeCard/metricCard.css Outdated Show resolved Hide resolved
@djeck1432 djeck1432 self-requested a review December 15, 2024 13:50
whateverfw
whateverfw requested changes Dec 15, 2024
View reviewed changes
Copy link
Collaborator

@whateverfw whateverfw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix unresolved issues

@djeck1432
Copy link
Owner

@canhamzacode Any updates? you will be unassigned soon 18 hours without update

@djeck1432
Copy link
Owner

@canhamzacode Texted you in telegram, waiting for changes or any updates

@djeck1432
Copy link
Owner

@canhamzacode Unassiged, has issue with laptop

@djeck1432 djeck1432 closed this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whateverfw whateverfw whateverfw requested changes

@djeck1432 djeck1432 Awaiting requested review from djeck1432

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Frontend] Fix Stake page UI [desktop/mobile]
3 participants
@canhamzacode @djeck1432 @whateverfw