Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: replaced pip with poetry #130

Merged
merged 7 commits into from
Oct 27, 2024
Merged

Feat: replaced pip with poetry #130

merged 7 commits into from
Oct 27, 2024

Conversation

vitaliypopel
Copy link
Collaborator

Has been deleted requirements.txt, changed Dockerfile and added pyproject.toml. At all pip was replaced with poetry

djeck1432
djeck1432 requested changes Oct 27, 2024
View reviewed changes
Copy link
Owner

@djeck1432 djeck1432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, attach also poetry.lock file

pyproject.toml Show resolved Hide resolved
@vitaliypopel
Copy link
Collaborator Author

@djeck1432 done with it

djeck1432
djeck1432 approved these changes Oct 27, 2024
View reviewed changes
Copy link
Owner

@djeck1432 djeck1432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@djeck1432 djeck1432 merged commit 433c1c8 into djeck1432:main Oct 27, 2024
2 checks passed
@djeck1432 djeck1432 linked an issue Oct 27, 2024 that may be closed by this pull request
Set up Poetry for project #123
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djeck1432 djeck1432 djeck1432 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set up Poetry for project
2 participants
@vitaliypopel @djeck1432