Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add unit tests for DashboardMixin methods #117

Merged
merged 6 commits into from
Oct 28, 2024
Merged

test: add unit tests for DashboardMixin methods #117

merged 6 commits into from
Oct 28, 2024

Conversation

0xdevcollins
Copy link
Contributor

No description provided.

@djeck1432 djeck1432 self-requested a review October 26, 2024 16:11
djeck1432
djeck1432 requested changes Oct 26, 2024
View reviewed changes
Copy link
Owner

@djeck1432 djeck1432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, run pylint $(git ls-files '*.py') --disable=all --enable=C0114,C0115,C0116,C0301 this comment, you have a lot of issues which you should

web_app/tests/test_dashboard_mixin.py Outdated Show resolved Hide resolved
web_app/tests/test_dashboard_mixin.py Outdated Show resolved Hide resolved
web_app/tests/test_dashboard_mixin.py Outdated Show resolved Hide resolved
@0xdevcollins
Copy link
Contributor Author

Okay ser. I'm on it

@djeck1432 djeck1432 marked this pull request as ready for review October 26, 2024 20:43
@djeck1432 djeck1432 linked an issue Oct 26, 2024 that may be closed by this pull request
Create test cases for dashboard #75
Closed
@djeck1432
Copy link
Owner

@0xdevcollins Please, fix your test cases: https://github.com/djeck1432/spotnet/actions/runs/11534530447/job/32109286816?pr=117

@0xdevcollins
Copy link
Contributor Author

@0xdevcollins Please, fix your test cases: https://github.com/djeck1432/spotnet/actions/runs/11534530447/job/32109286816?pr=117

okay

0xdevcollins

This comment was marked as duplicate.

Sign in to view

@djeck1432
Copy link
Owner

Please ,fix test cases
https://github.com/djeck1432/spotnet/actions/runs/11537998500/job/32117407959?pr=117
Before pushing or creating PR, make sure you run pytest command
@0xdevcollins

@0xdevcollins
Copy link
Contributor Author

Screenshot 2024-10-27 at 6 37 42 PM

@0xdevcollins
Copy link
Contributor Author

Please ,fix test cases https://github.com/djeck1432/spotnet/actions/runs/11537998500/job/32117407959?pr=117 Before pushing or creating PR, make sure you run pytest command @0xdevcollins

I did that ser, let me recheck and fix the issue. thank you

@djeck1432
Copy link
Owner

@0xdevcollins going to rerun pipeline

@djeck1432
Copy link
Owner

again failed, please, look at this result not what you have on your local machine
https://github.com/djeck1432/spotnet/actions/runs/11543187392/job/32127310428?pr=117
@0xdevcollins
text me in telegram please

@0xdevcollins
Copy link
Contributor Author

again failed, please, look at this result not what you have on your local machine https://github.com/djeck1432/spotnet/actions/runs/11543187392/job/32127310428?pr=117 @0xdevcollins text me in telegram please

okay

@djeck1432
Copy link
Owner

@0xdevcollins any updates?

djeck1432
djeck1432 approved these changes Oct 28, 2024
View reviewed changes
Copy link
Owner

@djeck1432 djeck1432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@djeck1432 djeck1432 merged commit 9e9125c into djeck1432:main Oct 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djeck1432 djeck1432 djeck1432 approved these changes

Assignees

@0xdevcollins 0xdevcollins

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create test cases for dashboard
2 participants
@0xdevcollins @djeck1432