-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DB/ Created Airdrop table in DB, Added crud methods #112
Conversation
@@ -30,13 +30,15 @@ def upgrade() -> None: | |||
if column_exists('position', 'start_price'): | |||
print("Column 'start_price' already exists, skipping creation.") | |||
else: | |||
op.add_column('position', sa.Column('start_price', sa.DECIMAL(), nullable=False)) | |||
op.add_column('position', sa.Column('start_price', sa.DECIMAL(), nullable=False, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you change old migration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
without this config its giving error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which error, please ,be more specific, if you have any error, attach it here with explanation what did you run the command to get this error and traceback of this error
@djeck1432 please review |
) | ||
print("Table 'airdrop' created successfully.") | ||
else: | ||
print("Table 'airdrop' already exists, skipping creation.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove print
use logging
@djeck1432 please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, approved
issue #104