Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DB/ Created Airdrop table in DB, Added crud methods #112

Merged
merged 17 commits into from
Oct 26, 2024

Conversation

binayak9932
Copy link
Contributor

issue #104

@@ -30,13 +30,15 @@ def upgrade() -> None:
if column_exists('position', 'start_price'):
print("Column 'start_price' already exists, skipping creation.")
else:
op.add_column('position', sa.Column('start_price', sa.DECIMAL(), nullable=False))
op.add_column('position', sa.Column('start_price', sa.DECIMAL(), nullable=False,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change old migration?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without this config its giving error

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which error, please ,be more specific, if you have any error, attach it here with explanation what did you run the command to get this error and traceback of this error

web_app/alembic/versions/e69320e12cc7_add_airdrop_model.py Outdated Show resolved Hide resolved
web_app/alembic/versions/e69320e12cc7_add_airdrop_model.py Outdated Show resolved Hide resolved
web_app/db/crud.py Outdated Show resolved Hide resolved
web_app/db/models.py Outdated Show resolved Hide resolved
@binayak9932 binayak9932 marked this pull request as ready for review October 25, 2024 21:36
@binayak9932 binayak9932 requested a review from djeck1432 October 25, 2024 21:36
@binayak9932
Copy link
Contributor Author

@djeck1432 please review

web_app/alembic/versions/e69320e12cc7_add_airdrop_model.py Outdated Show resolved Hide resolved
)
print("Table 'airdrop' created successfully.")
else:
print("Table 'airdrop' already exists, skipping creation.")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove print use logging

web_app/alembic/versions/e69320e12cc7_add_airdrop_model.py Outdated Show resolved Hide resolved
web_app/alembic/versions/e69320e12cc7_add_airdrop_model.py Outdated Show resolved Hide resolved
web_app/db/models.py Show resolved Hide resolved
web_app/tests/test_dbconnector.py Outdated Show resolved Hide resolved
@binayak9932
Copy link
Contributor Author

@djeck1432 please review

@binayak9932 binayak9932 requested a review from djeck1432 October 26, 2024 11:06
Copy link
Owner

@djeck1432 djeck1432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, approved

@djeck1432 djeck1432 merged commit 12d0954 into djeck1432:main Oct 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants