Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: start price field in position table #100

Merged

Conversation

tosoham
Copy link
Contributor

@tosoham tosoham commented Oct 24, 2024

Fixes #73
Continuation of PR #94

Copy link
Owner

@djeck1432 djeck1432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, make sure that pylint passed
you can run pylint $(git ls-files '*.py') --disable=all --enable=C0114,C0115,C0116,C0301 to verify it

web_app/db/crud.py Outdated Show resolved Hide resolved
web_app/db/models.py Outdated Show resolved Hide resolved
@tosoham tosoham requested a review from djeck1432 October 25, 2024 09:39
@tosoham tosoham requested a review from djeck1432 October 25, 2024 09:55
Copy link
Owner

@djeck1432 djeck1432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@djeck1432 djeck1432 merged commit cee5483 into djeck1432:main Oct 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new field to Position
2 participants