Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

funding.json (see https://floss.fund) #1753

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jacobian
Copy link
Member

@jacobian jacobian commented Nov 20, 2024

This adds a funding.json, which is a new format developed by https://floss.fund, required if we want to apply for funding from them. I'd like to, so here it is.

I don't love that this seems to require adding this funding-manifest-urls file to the github repo, that's a bit annoying, but otherwise it fails validation.

The alternate approach is to just add this as a static funding.json over in django/django and avoid any changes to the website. Doing it that way is certainly less code, but an advantage to doing it as a view is that we can dynamically render the funding tiers etc.

Copy link
Member

@bmispelon bmispelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks! 🎸

Some basic tests might be nice to have. I'm thinking a spot-check that the view is returning a well formed json, maybe also testing a few strategic keys of the response.

djangoproject/static/.well-known/funding-manifest-urls Outdated Show resolved Hide resolved
fundraising/views.py Outdated Show resolved Hide resolved
fundraising/views.py Outdated Show resolved Hide resolved
fundraising/views.py Outdated Show resolved Hide resolved
fundraising/views.py Outdated Show resolved Hide resolved
fundraising/views.py Outdated Show resolved Hide resolved
djangoproject/static/.well-known/funding-manifest-urls Outdated Show resolved Hide resolved
@jacobian
Copy link
Member Author

@bmispelon aw man you're gonna make me write tests!?

(yeah you're right, will do)

Copy link
Contributor

@marksweb marksweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides adding some tests as Baptiste says, this is great to see! 👏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants