Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify header text on community pages (#1563) #1614

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion aggregator/context_processors.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ def community_stats(request):
Context processor to calculate Django's age for the community pages.
"""
# Django 3.2 introduces depth kwarg. Set timesince(..., depth=1) then.
stats = {"age": timesince(DJANGO_DOB)}
stats = {"age": timesince(DJANGO_DOB, depth=1)}
return {"community_stats": stats}
7 changes: 7 additions & 0 deletions aggregator/tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
from django.core.management import call_command
from django.test import SimpleTestCase, TestCase
from django.urls import reverse
from django.utils.timesince import timesince

from docs.models import DocumentRelease
from releases.models import Release
Expand Down Expand Up @@ -143,6 +144,12 @@ def test_feedtype_items_has_only_approved(self):
transform=attrgetter("title"),
)

def test_header_text_simplification_shows_only_years(self):
django_dob = datetime.datetime(2005, 7, 21)
age = timesince(django_dob, depth=1)
self.assertIn("years", age)
self.assertNotIn("months", age)


class TestForms(SimpleTestCase):
def test_rejects_stackoverflow_questions(self):
Expand Down
Loading