Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion at #356 ,
django-elasticsearch-dsl
lacks aDenseVectorField
corresponding to theDenseVector
field defined inelasticsearch-dsl
https://github.com/elastic/elasticsearch-dsl-py/blob/579f57205c395e17024d9ae827cbf6fd626969c4/elasticsearch_dsl/field.py#L392-L397
This PR adds this field type.
The patch has been used as
where
get_embedding
is a function that returns a list of embeddings. Embeddings returned inarray
type does not work becausedjango-elasticsearch-dsl/django_elasticsearch_dsl/fields.py
Lines 89 to 90 in e453aff
will fail if an array is compared to
None
.