Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add migrations for Django 4.2 #73

Merged
merged 15 commits into from
Dec 6, 2023

Conversation

mogoh
Copy link
Contributor

@mogoh mogoh commented Aug 2, 2023

Description

Work in progress, not ready to merge yet.

Related resources

#72

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

@fsbraun
Copy link
Member

fsbraun commented Aug 2, 2023

@mogoh For the tests to run, you'll need to drop mptt from the test/settings.py.

Can I suggest to also add tests for django CMS 4.1? This could then also be reflected in the readme and setup.py.

Thank you for pushing this!

setup.py Show resolved Hide resolved
@mogoh mogoh force-pushed the feat-django-4-2-support branch 2 times, most recently from 2b831f3 to dcc49f9 Compare August 21, 2023 12:49
@mogoh mogoh force-pushed the feat-django-4-2-support branch from dcc49f9 to ebac569 Compare August 21, 2023 13:01
@mogoh mogoh marked this pull request as ready for review August 21, 2023 16:10
@mogoh
Copy link
Contributor Author

mogoh commented Aug 21, 2023

Please review.

Copy link

@tidenhub tidenhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Looks good to me.

@fsbraun fsbraun closed this Dec 6, 2023
@fsbraun fsbraun reopened this Dec 6, 2023
Copy link
Member

@fsbraun fsbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much, @mogoh !

@fsbraun fsbraun merged commit 9f9addc into django-cms:master Dec 6, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants