pre-commit hook updates #25
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #25 +/- ##
==========================================
- Coverage 32.19% 32.10% -0.10%
==========================================
Files 11 11
Lines 382 380 -2
Branches 56 56
==========================================
- Hits 123 122 -1
+ Misses 259 258 -1 ☔ View full report in Codecov by Sentry. |
| rev: '1.4.0' | ||
| hooks: | ||
| - id: django-upgrade | ||
| args: [--target-version, "2.2"] |
There was a problem hiding this comment.
I think this is one of the things you asked about on Slack and its a bit easier to respond here.
This version is the minimum supported version. This tool will optimise the Django specific code in a commit, using the features available in Django 2.2.
| rev: v3.2.0 | ||
| hooks: | ||
| - id: pyupgrade | ||
| args: ["--py37-plus"] |
There was a problem hiding this comment.
Just like the Django version, this is the minimum supported python version. Python code in a commit is then optimised to match the features in this python version.
There was a problem hiding this comment.
Alright Mark, thanks for clarifying
Pipfile.lock
Outdated
| @@ -0,0 +1,146 @@ | |||
| { | |||
Pipfile
Outdated
| @@ -0,0 +1,12 @@ | |||
| [[source]] | |||
| @@ -0,0 +1,44 @@ | |||
| repos: | |||
There was a problem hiding this comment.
Could you add the ci config from here please?
https://github.com/django-cms/django-cms/blob/develop/.pre-commit-config.yaml
And you can just remove the black section rather than comment out as we've no plans to use black
There was a problem hiding this comment.
I already removed the commented code in my last commit.
|
Okay, doing it now.
…On Tue, 1 Nov 2022 at 21:03, Mark Walker ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In .pre-commit-config.yaml
<#25 (comment)>
:
> @@ -0,0 +1,44 @@
+repos:
Could you add the ci config from here please?
https://github.com/django-cms/django-cms/blob/develop/.pre-commit-config.yaml
And you can just remove the black section rather than comment out as we've
no plans to use black
—
Reply to this email directly, view it on GitHub
<#25 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACIB3UKGLRC7E66N2VOUOPLWGFZR3ANCNFSM6AAAAAARSUJJL4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Description
Related resources
Checklist
masterSlack to find a “pr review buddy” who is going to review my pull request.