-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add table support for TipTap editor #42
Conversation
Reviewer's Guide by SourceryThis PR adds support for tables in the TipTap editor, including creating tables, adding/deleting rows and columns, merging/splitting cells, and resizing columns. Sequence diagram for table creation and manipulationsequenceDiagram
actor User
participant TB as Table Button
participant Editor as TipTap Editor
participant Table as Table Component
User->>TB: Click table button
TB->>Editor: Show table size selector
User->>TB: Select dimensions (1x1 to 10x10)
TB->>Editor: insertTable(rows, cols)
Editor->>Table: Create table
Note over User,Table: Table Manipulation
User->>Table: Modify table structure
Table->>Editor: Update table
Editor->>Table: Apply changes
Note over User,Table: Column Resizing
User->>Table: Drag column border
Table->>Editor: Update column width
Editor->>Table: Apply new dimensions
Class diagram for TipTap table toolbar implementationclassDiagram
class TiptapToolbar {
+Table
+addColumnBefore
+addColumnAfter
+deleteColumn
+addRowBefore
+addRowAfter
+deleteRow
+mergeOrSplit
}
class TableConfig {
+resizable: true
+HTMLAttributes: object
}
class TableActions {
+generateButtonArray(rows, cols)
+generateTableMenu(editor, builder)
}
TiptapToolbar -- TableActions
TableActions -- TableConfig
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #42 +/- ##
=======================================
Coverage 81.16% 81.16%
=======================================
Files 17 17
Lines 929 929
Branches 104 104
=======================================
Hits 754 754
Misses 132 132
Partials 43 43 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @fsbraun - I've reviewed your changes - here's some feedback:
Overall Comments:
- There's a console.log statement in cmsplugins/plugin.js that should be removed before merging
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
This PR adds table support for the TipTap RTE:
Fixes #21
Summary by Sourcery
Add support for table manipulation in the TipTap editor.
New Features:
Tests:
Summary by Sourcery
Add support for creating and manipulating tables in the TipTap editor.
New Features:
Tests: