-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Clean up ckeditor4 vendor files #39
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request #39 has too many files changed.
We can only review pull requests with up to 300 changed files, and this pull request has 387.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
==========================================
+ Coverage 80.43% 81.16% +0.73%
==========================================
Files 17 17
Lines 930 929 -1
Branches 104 104
==========================================
+ Hits 748 754 +6
+ Misses 138 132 -6
+ Partials 44 43 -1 ☔ View full report in Codecov by Sentry. |
I've just installed this branch in replacement of the 0.3.3 package and it seems to lacks of bundles, i got these assets failing on 404 response:
And so the editor is broken. |
-- ah, ok. The repo does not include the builds. You'll have to clone the repo and run
To create the bundle. Install using |
Ok i've installed it from branch repo then built the frontend and it works without any errors. By the way you have a console warning log emitted from here: |
Fixes #38 by reorganizing the ckeditor4 assets systematically.
Also, update to ckeditor 4.22.1, the last OSS release, and disable version warning.
@sveetch Can you give this a test run?