Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Clean up ckeditor4 vendor files #39

Merged
merged 6 commits into from
Dec 12, 2024
Merged

fix: Clean up ckeditor4 vendor files #39

merged 6 commits into from
Dec 12, 2024

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented Dec 12, 2024

Fixes #38 by reorganizing the ckeditor4 assets systematically.
Also, update to ckeditor 4.22.1, the last OSS release, and disable version warning.

@sveetch Can you give this a test run?

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request #39 has too many files changed.

We can only review pull requests with up to 300 changed files, and this pull request has 387.

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.16%. Comparing base (1e3ebc2) to head (a4f4b07).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
+ Coverage   80.43%   81.16%   +0.73%     
==========================================
  Files          17       17              
  Lines         930      929       -1     
  Branches      104      104              
==========================================
+ Hits          748      754       +6     
+ Misses        138      132       -6     
+ Partials       44       43       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fsbraun fsbraun changed the title fix: Clean up ckeditor4 editor fix: Clean up ckeditor4 vendor files Dec 12, 2024
@sveetch
Copy link
Contributor

sveetch commented Dec 12, 2024

I've just installed this branch in replacement of the 0.3.3 package and it seems to lacks of bundles, i got these assets failing on 404 response:

  • /static/djangocms_text/bundles/bundle.editor.min.js
  • /static/djangocms_text/bundles/bundle.ckeditor4.min.js

And so the editor is broken.

@fsbraun
Copy link
Member Author

fsbraun commented Dec 12, 2024

-- ah, ok. The repo does not include the builds. You'll have to clone the repo and run

# nvm use
# npx webpack --mode development

To create the bundle. Install using pip install -e /path/to/clone. Does that make sense? Sorry for the inconvenience.

@sveetch
Copy link
Contributor

sveetch commented Dec 12, 2024

Ok i've installed it from branch repo then built the frontend and it works without any errors.

By the way you have a console warning log emitted from here:
https://github.com/django-cms/djangocms-text/blob/main/private/js/cms.ckeditor4.js#L112

@fsbraun fsbraun merged commit 83bfa2a into main Dec 12, 2024
29 checks passed
@fsbraun fsbraun deleted the fix/ckeditor4-assets branch December 12, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RTEConfig for 'ckeditor4' is loading 'ckeditor.js' from a wrong path
2 participants