-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Integrate Jest for JavaScript testing with CI setup #28
Conversation
Set up a modern JavaScript testing framework using Jest, integrated with the existing webpack build system. Configure Babel for modern JavaScript support and establish a test file structure and conventions. Update the package.json to include Jest dependencies and scripts for running tests, watching tests, and generating coverage reports. Set up a continuous integration pipeline to run JavaScript tests alongside existing Python tests. New Features: - Introduce a modern JavaScript testing framework using Jest, integrated with the existing webpack build system. Enhancements: - Configure Babel for modern JavaScript support with a new Babel configuration file. CI: - Set up a continuous integration pipeline to run JavaScript tests alongside existing Python tests. Tests: - Establish a test file structure and conventions for JavaScript tests, including an example test file to verify the setup. - Configure test coverage reporting for JavaScript code. Resolves #27
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a github action that run the javascript tests
@sourcery-ai update |
I'm sorry, I don't understand the command Please use |
@sourcery-ai review |
Reviewer's Guide by SourceryThis PR implements a JavaScript testing infrastructure using Jest, integrated with the existing webpack build system. The implementation includes Jest configuration, Babel setup for modern JavaScript support, test file structure setup, and CI integration. The changes primarily involve adding necessary dependencies, configuring Jest and Babel, and setting up test utilities and example tests. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @sourcery-ai[bot] - I've reviewed your changes - here's some feedback:
Overall Comments:
- There are duplicate devDependencies in package.json for @babel/core, @babel/preset-env, @testing-library/dom, @testing-library/jest-dom, babel-jest, jest, and jest-environment-jsdom. Please remove the duplicated entries.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
"webpack-cli": "^5.1.4", | ||
"@babel/core": "^7.24.0", | ||
"@babel/preset-env": "^7.24.0", | ||
"@testing-library/dom": "^9.3.4", | ||
"@testing-library/jest-dom": "^6.4.2", | ||
"babel-jest": "^29.7.0", | ||
"jest": "^29.7.0", | ||
"jest-environment-jsdom": "^29.7.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (bug_risk): Remove duplicate dev dependencies
Several dependencies (@babel/core, @babel/preset-env, @testing-library/dom, @testing-library/jest-dom, babel-jest, jest, jest-environment-jsdom) are listed twice with different versions. This could cause confusion and potential version conflicts. Please remove the duplicate entries and keep only one version of each dependency.
…s-text into sourcery-ai/issue-27
Resolves #27
Set up a modern JavaScript testing framework using Jest, integrated with the existing webpack build system. Configure Babel for modern JavaScript support and establish a test file structure and conventions. Update the package.json to include Jest dependencies and scripts for running tests, watching tests, and generating coverage reports. Set up a continuous integration pipeline to run JavaScript tests alongside existing Python tests.
New Features:
Enhancements:
CI:
Tests:
This PR was automatically generated.
If you want to make changes to this PR:
Summary by Sourcery
Integrate Jest for JavaScript testing, configure Babel for modern JavaScript support, and establish a CI pipeline to run JavaScript tests alongside existing Python tests. Update package.json to include Jest dependencies and scripts for running tests, watching tests, and generating coverage reports.
New Features:
Enhancements:
CI:
Tests: