Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Bump actions/upload-artifact from 3 to 4" #173

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented Nov 26, 2024

Reverts #147

Summary by Sourcery

CI:

  • Revert the GitHub Actions workflow to use actions/upload-artifact version 3 instead of version 4.

Copy link

sourcery-ai bot commented Nov 26, 2024

Reviewer's Guide by Sourcery

This PR reverts a previous change that upgraded the actions/upload-artifact GitHub Action from version 3 to version 4. The implementation simply changes the version number back from v4 to v3 in the GitHub Actions workflow file.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Downgrade actions/upload-artifact GitHub Action from v4 to v3
  • Reverted version from v4 to v3 for uploading coverage data
  • Reverted version from v4 to v3 for uploading HTML report on failure
.github/workflows/test.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @fsbraun - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please provide context on why this revert was necessary. What issues were encountered with actions/upload-artifact v4 that required rolling back to v3?
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant