Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Django 4.2 support #256

Closed

Conversation

Aiky30
Copy link
Collaborator

@Aiky30 Aiky30 commented Mar 7, 2024

What does this PR do?

  • Adds python 3.10, 3.11 and 3.12 support
  • Removes djangocms-version-locking as a dependancy, becasue it's not a DCA supported package
  • Removes aldryn-forms, because it's deprecated and the featureset is not actually used anywhere as far as I am aware.
  • Removes python 3.7 and 3.8 support

Remaining issues to fix:

  • Monkey patching on versioning states (should be a plan to move away from these in the near future by designing versioning to be overridden properly)
  • Confirmation page can add a "form", this form was supposed to be a form builder. It was never used, but the ability to add plain confirmation pages, or templates is still possible so only a minor degradation.
  • Check with Josh if any entries are present for "Confirmation Pages" to be sure that no one is using the confirmation page form builder. If not, destruct it completely.

@@ -10,10 +10,10 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: [ 3.7, 3.8, 3.9 ] # latest release minus two
python-version: [ 3.9, 3.10, 3.11, 3.12 ] # latest release minus two
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.10 , 3.11, 3.12 should be wrapped with quotation mark, otherwise yaml will be incorrectly analyzed.

@wfehr
Copy link

wfehr commented Mar 11, 2024

I tried installing djangocms-moderation with this fork but the migrations fail for an initial setup of the database.
I don't know if it's a problem with this fork (i.e. with this changes mysql 8 is possible) or a general error also occuring with mysql 5 (= django 4.1):

ValueError: The database backend does not accept 0 as a value for AutoField.

This occurs from migration djangocms_moderation.0003_auto_20180903_1206 which provided a one-off-default for a ForeignKey with the value 0.

@wfehr
Copy link

wfehr commented Mar 11, 2024

I tried installing djangocms-moderation with this fork but the migrations fail for an initial setup of the database. I don't know if it's a problem with this fork (i.e. with this changes mysql 8 is possible) or a general error also occuring with mysql 5 (= django 4.1):

ValueError: The database backend does not accept 0 as a value for AutoField.

This occurs from migration djangocms_moderation.0003_auto_20180903_1206 which provided a one-off-default for a ForeignKey with the value 0.

Just tried it with installing django = 4.1 - same error. I'll create a new issue für this.

@Aiky30
Copy link
Collaborator Author

Aiky30 commented Mar 12, 2024

This change has been superseded by: #262

@Aiky30 Aiky30 closed this Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants