Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add dir attribute to html tag in djangocms_frontend.html #204

Merged
merged 1 commit into from
Apr 13, 2024

Conversation

sakhawy
Copy link
Contributor

@sakhawy sakhawy commented Apr 13, 2024

Description

Added dir attribute to the html tag for #7871 to take effect.

Related resources

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on Slack to find a “pr review buddy” who is going to review my pull request.

Copy link

codecov bot commented Apr 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.91%. Comparing base (f11feee) to head (1605b63).
Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #204      +/-   ##
==========================================
- Coverage   86.93%   86.91%   -0.02%     
==========================================
  Files         120      120              
  Lines        3107     3119      +12     
  Branches      330      331       +1     
==========================================
+ Hits         2701     2711      +10     
+ Misses        304      303       -1     
- Partials      102      105       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fsbraun fsbraun merged commit b3100fc into django-cms:master Apr 13, 2024
46 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants