Updated some bugs and enhancements #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
svandeneertwegh
commented
Sep 23, 2023
svandeneertwegh
commented
- Removed col and rows setting from CharField form plugin
- Set more margin options in spacing between fields
- Fixed anonymous as None to Foregin key 'form_user'
fsbraun
reviewed
Sep 23, 2023
| @@ -69,7 +70,6 @@ class CharFieldPlugin(mixin_factory("CharField"), FormElementPlugin): | |||
| name = _("Text") | |||
| model = models.CharField | |||
| form = forms.CharFieldForm | |||
| settings_fields = (("min_length", "max_length"),) | |||
There was a problem hiding this comment.
Why do you remove min_length and max_length? aren't they potentially needed for form validation?
fsbraun
reviewed
Sep 23, 2023
| @@ -20,7 +20,15 @@ | |||
| framework = getattr(django_settings, "DJANGOCMS_FRONTEND_FRAMEWORK", "bootstrap5") | |||
| theme = getattr(django_settings, "DJANGOCMS_FRONTEND_THEME", "djangocms_frontend") | |||
|
|
|||
| DEFAULT_SPACER_SIZE_CHOICES = (("mb-3", "Default"),) | |||
There was a problem hiding this comment.
I'd rather ask you to set this in your settings. It will first try to take DJANGO_FORM_BUILDER_SPACER_CHOICES then take django CMS frontend's settings if available.
fsbraun
reviewed
Sep 23, 2023
| @@ -0,0 +1,28 @@ | |||
| from django.utils.translation import gettext_lazy as _ | |||
| from djangocms_frontend.helpers import insert_fields | |||
There was a problem hiding this comment.
You should not assume django CMS frontend is installed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.