Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cms_plugins.py - now using cms.api to add columns #59

Closed
wants to merge 1 commit into from

Conversation

aacimov
Copy link
Contributor

@aacimov aacimov commented May 10, 2024

Using cms.api to make the plugin compatible with django-cms v4 as well. This patch also works for django-cms v3.

Description

Changed cms_plugins.py save_model method to make the plugin work with django-cms v3 and v4 by using the cms.api for adding columns.

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

Using cms.api to make the plugin compatible with django-cms v4 as well. This patch also works for django-cms v3
@fsbraun fsbraun closed this May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants