Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: history summary #520

Merged
merged 3 commits into from
Mar 30, 2024

Conversation

raffaellasuardini
Copy link
Contributor

Description

As mentioned in the issue, the left padding in the page history has been updated.

Before:
#change-history .paginator,.change-list table .paginator,.dashboard table .paginator,.results table .paginator,.tabular table .paginator {
    box-shadow: none!important;
}

After:

#change-history .paginator,.change-list table .paginator,.dashboard table .paginator,.results table .paginator,.tabular table .paginator {
    box-shadow: none!important;
    padding-left: 10px;
    box-sizing: border-box;
}

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f1bbc9d) to head (721fc91).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #520   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           33        33           
  Branches         3         3           
=========================================
  Hits            33        33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fsbraun
Copy link
Member

fsbraun commented Mar 26, 2024

@raffaellasuardini Can you rebase your fork and make the change to the corresponding sass file? This is compile into the css. Only changes in the sass files will be persistent.

@raffaellasuardini
Copy link
Contributor Author

Sure @fsbraun. I'm going to work on it.

@fsbraun
Copy link
Member

fsbraun commented Mar 29, 2024

@raffaellasuardini Can you also run gulp sass to update the css assets?

@raffaellasuardini
Copy link
Contributor Author

@fsbraun I ran the gulp file but it also created files like.eot .ttfand .woff should I also include them?

@fsbraun
Copy link
Member

fsbraun commented Mar 29, 2024

Yes, please do that. Sometimes updates on the compiler lead to minor changes in the binaries.

@fsbraun fsbraun merged commit 8edbd66 into django-cms:master Mar 30, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants