Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove flex display for submit-row (as of Django 4.2) #507

Merged
merged 5 commits into from
Jan 13, 2024

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented Jan 10, 2024

This PR resets display values of the submit row and admin header back to block as djangocms-admin-style expects.
Django 4.2+ uses flex.

Additionally, the .deletelink does not be inside a .deletelink-box any more.

Fixes #506

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7ee48a8) 100.00% compared to head (3032e8e) 100.00%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #507   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           33        33           
  Branches         3         3           
=========================================
  Hits            33        33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fsbraun fsbraun requested a review from a team January 11, 2024 14:01
Copy link
Member

@vinitkumar vinitkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's get this merged and released 🚢 🚀

@vinitkumar vinitkumar merged commit 1428c0d into django-cms:master Jan 13, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button layout/sizes with Django 4.2 and CMS 3.11
2 participants