Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update com.oxygenxml.json.dita.json to work with latest DITA OT versions #154

Closed
wants to merge 2 commits into from

Conversation

raducoravu
Copy link
Member

Description

Small changes to Java code in order to make plugin work with DITA OT 4.x.

@jelovirt
Copy link
Member

Sign-off is missing and the hash hasn't been updated so it doesn't match the new URI. Preferably you could keep the old version metadata and add a new version

Signed-off-by: Radu Coravu <[email protected]>
@raducoravu
Copy link
Member Author

@jelovirt I updated the checksum and added a signoff on my second commit.
Btw I'm using "CatalogUtils.getCatalogResolver()" in my JSON parser code:
https://github.com/oxygenxml/dita-json/blob/master/com.oxygenxml.json.dita/src/com/oxygenxml/json/dita/JSONReader.java
Does this mean that after your latest changes this method will disappear as it was moved to the XML utilities class? Or did you leave it deprecated?

@jelovirt
Copy link
Member

I updated the checksum and added a signoff on my second commit.

You have to add a sign-off to every commit. I suggest you squash the commits into one and make sure that has the sign-off.

@raducoravu
Copy link
Member Author

@jelovirt thinking that the "com.oxygenxml.json.dita.json" plugin is more of a build-your-own thing where people need to edit an XSLT stylesheet in order to obtain the proper DITA XML topic that they want to obtain from the JSON content, maybe the proper thing to do would be for me to close this pull request and open another one in which I remove the plugin from the registry which should in general keep plugins which are usable as they are or which define parameters to customize them, not plugins which require editing content inside the plugin folder.

@raducoravu raducoravu closed this Jun 25, 2024
@raducoravu raducoravu deleted the raducoravu-patch-1 branch June 25, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants