-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding docker submodule #59
Conversation
Wow! Awesome work! Our team has been very busy with blockchain indexing, we literally wrote a lot of new code in monorepo for blockchain indexing. We are already at the finish line. Soon we will make important updates for toncli and updates will come out more often :) I think the idea of running toncli in such an easy way from a container is very cool! We will check docker. Maybe it's better to use docker-registry for easy to pull it? |
For sure! Idea is to publish it to the registry at some point, so people could just pull it as is without having to go through build process. Glad that you liked the idea! |
Maybe i should add tonlibjson to it? |
@Trinketer22 will be great! Also, could you publish it to docker-hub, so we can provide short way of install? |
That's definitely the plan, but isn't it too soon to do it? |
From dev-chat discussion: https://t.me/tondev/89471 I think that it's cool to have some slim docker image (around 80mb) and have bash script for fast usage |
I don't know if it even possible to get it that small, but maybe some android distro like alpine linux as a base could help. |
@Trinketer22 we also will release docker-hub version of Check out @TrueCarry work of optimization size: https://github.com/disintar/ton-k8s/pull/1/files#diff-458cb69809c9c61256fda581953e47fc00d34e6ea44cadbfd164577c0edfdcc3 Slim version is around 80mb :) |
python-slim is ~50mb, while python-bullseye 300+mb. Changing base really helps. Main problem is you need gcc to install some python requirements, but you can actually install and remove it in one step and it won't waste any space in resulting image. |
Ok challenge accepted |
python:3.10-slim is actually 126MB. Via using alpine base i've managed so far to get 136MB resulting image. |
Next steps are:
|
Here we go! |
Thanks for work, added to installation.md in 353d8db |
Hey!
I think this one might come in handy to temporary relief most of the pain that comes with binaries/toncli versions issues.
At least till the day when
pip install toncli
will just work with all the new features.New tests are far better than the old ones s people using toncli, are going to need to switch to those ASAP.
Otherwise legacy code is going to continue to grow and cause pain to everyone.
Only way i see to quickly and reliably do it at this stage is moving towards containerized development.
What i'm proposing with this PR is to make some toncli approved container for people to work from.
I doesn't have to be my container, because it's not tested much yet at the moment, but it would be much easier to start if there was one.
Also there is probably better way to let people know about the existence of the new tests.
Not many people read docs/advanced till they feel completely lost.
I think it would be much better if there was at least a separate paragraph in quickstart more insistingly leading towards how tests work.
Or maybe even on the front README.md
Has at least to do with issue:#36