Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rough calibration if the calibrator's elevation was too far from the source's #246

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

matteobachetti
Copy link
Collaborator

@matteobachetti matteobachetti commented Dec 28, 2024

The elevation-calibration law calculated in SDTcal is a linear function, and it can be imprecise outside the fitted range, to the point that it could even get to negative values.
Now, the code will through a warning when this happens, and use a rougher constant calibration which should be more robust outside the validity range.

Also here:

  • Exit cleanly if no valid calibration is present for a given channel (and suggest way to get a valid one)
  • Better logging
  • Fix for recent Numpy/Astropy/HDF5

@matteobachetti matteobachetti removed the request for review from giuseppe-carboni December 28, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant