Fix summary #242
Merged
Fix summary #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteobachetti
force-pushed
the
fix_summary
branch
from
67232fb to
bb9c0a8
Compare
matteobachetti
requested review from
sergiopoppi and
giuseppe-carboni
and removed request for
sergiopoppi and
giuseppe-carboni
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #242 +/- ##
===========================================
+ Coverage 77.08% 93.00% +15.92%
===========================================
Files 25 25
Lines 6296 6308 +12
===========================================
+ Hits 4853 5867 +1014
+ Misses 1443 441 -1002 ☔ View full report in Codecov by Sentry. |
giuseppe-carboni
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #240
Based on my understanding of the new naming convention, I now single out Summary files from either being "summary.fits" or starting by "Sum_", case-insensitive. Is there any other inference I should do on the file name?
PS: While doing this, I found another bug that I also resolve here: resolve #243