Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Implement data cubes. #192

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

matteobachetti
Copy link
Collaborator

@matteobachetti matteobachetti commented Feb 3, 2020

This PR aims at producing data cubes out of SDTimager. The functionality is more or less there, but we need to change the code in a few points

  • We need fast histogram functions for the increased data size.
  • When we load new subscans, we have to preserve the spectral information.
  • The histogram2d functions in imager.py:559-- have to be substituted by histogram3d functions, and the 2-d case has to work as a special case with a single bin along the 3rd dimension
  • Calibration has to take into account this new format
  • The output data format of images has to change slightly to accommodate these cubes, and revert to the 2d case for non-spectroscopic images.
  • Desideratum: as the increased data size might fill up the memory, this might be a good moment to implement some sort of memory mapping.

@codecov-io
Copy link

codecov-io commented Feb 3, 2020

Codecov Report

Merging #192 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #192   +/-   ##
=======================================
  Coverage   93.77%   93.77%           
=======================================
  Files          23       23           
  Lines        5867     5867           
=======================================
  Hits         5502     5502           
  Misses        365      365
Impacted Files Coverage Δ
srttools/utils.py 94.23% <100%> (ø) ⬆️
srttools/imager.py 94.05% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a01059f...438c9f4. Read the comment docs.

@matteobachetti
Copy link
Collaborator Author

Current progress: most functionality works. Need to fix problems with the baseline subtraction (somehow, it is sometimes run on spectroscopic data instead of total power)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants