Support multi line separator #130
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #130 +/- ##
==========================================
+ Coverage 67.70% 69.11% +1.40%
==========================================
Files 48 45 -3
Lines 703 654 -49
Branches 213 195 -18
==========================================
- Hits 476 452 -24
+ Misses 99 95 -4
+ Partials 128 107 -21 ☔ View full report in Codecov by Sentry. |
|
I don't think we need to cover this generated class with tests. |
to visually distinguish them from tokens and states
…e in line
According to structurizr dsl parser, the script ends once a line with a single rbrace ('}') is met.
See https://github.com/structurizr/java/blob/39bf3d0890afc4caa52cf3302269a12fc2a4236b/structurizr-dsl/src/main/java/com/structurizr/dsl/StructurizrDslParser.java#L208
goto1134
force-pushed
the
support-line-continuations
branch
from
6932cf0
to
d6e30ce
Compare
|
@dirkgroot , what do you think about this change? |
|
@goto1134 I'm sorry for the delay. Unfortunately I currently don't have a lot of time available to review your PR. I'll try to take at look at this sometime in the upcoming 2 weeks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #110