Skip to content
This repository has been archived by the owner on Jun 21, 2022. It is now read-only.

add support for Loki ruler configuration #1

Open
wants to merge 26 commits into
base: master
Choose a base branch
from

Conversation

weakcamel
Copy link

update also broken Loki documentation link

update also broken Loki documentation link
@weakcamel
Copy link
Author

@diogenxs Not sure if you care about this role anymore, but I thought I'd try to merge my changes back, just in case.

P.S. Thank you for writing it in the first place, it's very handy!

@rutger1140
Copy link

@weakcamel Nice work on the updates. I'm actually only looking for adding the ruler setting. I'll create another PR for that.

I can imagine that @diogenxs won't approve your PR when you remove his name from the meta/main.yml file 😛 😉

@weakcamel
Copy link
Author

I can imagine that @diogenxs won't approve your PR when you remove his name from the meta/main.yml file 😛 😉

Lol, that's a good point. I actually assumed that the original author is no longer interested in maintaining this role so I need to go with my fork anyway. Should I be wrong though, i'm happy to revert that bit in this PR (or someone else to revert that).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants