forked from getodk/collect
-
Notifications
You must be signed in to change notification settings - Fork 0
‐Fix for #5678 …snackbar reappears…
David Wright edited this page Aug 15, 2023
·
1 revision
Thanks for the tip, a bit advanced for me but I got it to work after some puzzling.
I've also tested with a dummyFailedValidationResult
.
And thanks @ln for the kind welcome, it's nice to be back.
Closes #5678?
Tested manually.
Seems to be "the simplest thing that could possibly work". More elegant alternatives could be to change the signature of FormEntryViewModel.getValidationResult
to reflect the actual class; or completely encapsulate with something like resetValidationResult
.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Behaviour is now as expected. Doesn't break any tests.
No?
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
- run
./gradlew checkAll
and confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTest
locally. - verified that any code or assets from external sources are properly credited in comments and/or in the about file.
- verified that any new UI elements use theme colors. UI Components Style guidelines