fix nil deref when posting without authentication

dimkr · Dec 14, 2024 · 2cd60e6 · 2cd60e6
1 parent 1d4cd3d
commit 2cd60e6
Show file tree

Hide file tree

Showing 5 changed files with 35 additions and 5 deletions.
diff --git a/front/dm.go b/front/dm.go
@@ -22,6 +22,11 @@ import (
 )
 
 func (h *Handler) dm(w text.Writer, r *Request, args ...string) {
+	if r.User == nil {
+		w.Redirect("/users")
+		return
+	}
+
 	to := ap.Audience{}
 	cc := ap.Audience{}
 
@@ -31,6 +36,11 @@ func (h *Handler) dm(w text.Writer, r *Request, args ...string) {
 }
 
 func (h *Handler) uploadDM(w text.Writer, r *Request, args ...string) {
+	if r.User == nil {
+		w.Redirect("/users")
+		return
+	}
+
 	to := ap.Audience{}
 	cc := ap.Audience{}
 

diff --git a/front/post.go b/front/post.go
@@ -43,11 +43,6 @@ var (
 )
 
 func (h *Handler) post(w text.Writer, r *Request, oldNote *ap.Object, inReplyTo *ap.Object, to ap.Audience, cc ap.Audience, audience string, readInput inputFunc) {
-	if r.User == nil {
-		w.Redirect("/users")
-		return
-	}
-
 	now := ap.Time{Time: time.Now()}
 
 	if oldNote == nil {

diff --git a/front/reply.go b/front/reply.go
@@ -24,6 +24,11 @@ import (
 )
 
 func (h *Handler) doReply(w text.Writer, r *Request, args []string, readInput inputFunc) {
+	if r.User == nil {
+		w.Redirect("/users")
+		return
+	}
+
 	postID := "https://" + args[1]
 
 	var note ap.Object

diff --git a/front/say.go b/front/say.go
@@ -22,6 +22,11 @@ import (
 )
 
 func (h *Handler) say(w text.Writer, r *Request, args ...string) {
+	if r.User == nil {
+		w.Redirect("/users")
+		return
+	}
+
 	to := ap.Audience{}
 	cc := ap.Audience{}
 
@@ -34,6 +39,11 @@ func (h *Handler) say(w text.Writer, r *Request, args ...string) {
 }
 
 func (h *Handler) uploadSay(w text.Writer, r *Request, args ...string) {
+	if r.User == nil {
+		w.Redirect("/users")
+		return
+	}
+
 	to := ap.Audience{}
 	cc := ap.Audience{}
 

diff --git a/front/whisper.go b/front/whisper.go
@@ -22,6 +22,11 @@ import (
 )
 
 func (h *Handler) whisper(w text.Writer, r *Request, args ...string) {
+	if r.User == nil {
+		w.Redirect("/users")
+		return
+	}
+
 	to := ap.Audience{}
 	cc := ap.Audience{}
 
@@ -33,6 +38,11 @@ func (h *Handler) whisper(w text.Writer, r *Request, args ...string) {
 }
 
 func (h *Handler) uploadWhisper(w text.Writer, r *Request, args ...string) {
+	if r.User == nil {
+		w.Redirect("/users")
+		return
+	}
+
 	to := ap.Audience{}
 	cc := ap.Audience{}