Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace quickcheck by proptest #837

Merged
merged 18 commits into from
Mar 1, 2021
Merged

Replace quickcheck by proptest #837

merged 18 commits into from
Mar 1, 2021

Conversation

sebcrozet
Copy link
Member

@sebcrozet sebcrozet commented Feb 28, 2021

This PR replaces all our tests based on quickcheck with tests based on proptest.
With its version 1.0, quickcheck has the following issue:

These two issues makes quickcheck basically unusable by nalgebra

Proptest on the over hands allows us to specify the kind of values we want to test with very easily. @Andlon already did a significant amount of work to use proptest with nalgebra because proptest is already used in nalgebra-sparse. So even if quickcheck didn't have the two aforementioned issues, it would make sense to switch to proptest anyway.

@sebcrozet
Copy link
Member Author

sebcrozet commented Mar 1, 2021

For some reasons, CircleCI is now failing lots of tests randomly. This appears to be caused by not having enough memory.
So I'm switching to GitHub Actions instead which does not have this problem.

@sebcrozet sebcrozet merged commit b97a3d0 into dev Mar 1, 2021
@sebcrozet sebcrozet deleted the proptest branch March 1, 2021 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant