-
-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace quickcheck by proptest #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reasons, CircleCI is now failing lots of tests randomly. This appears to be caused by not having enough memory. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces all our tests based on quickcheck with tests based on proptest.
With its version 1.0, quickcheck has the following issue:
NaN
: make arbitrary generate full range of integers BurntSushi/quickcheck#240 These extreme values will obviously make most of our tests fail.These two issues makes quickcheck basically unusable by nalgebra
Proptest on the over hands allows us to specify the kind of values we want to test with very easily. @Andlon already did a significant amount of work to use proptest with nalgebra because proptest is already used in
nalgebra-sparse
. So even if quickcheck didn't have the two aforementioned issues, it would make sense to switch to proptest anyway.