Improve system schedules #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on top of #576 to more easily visualize the impacts
This change doesn´t impact the execution, but orders systems more consistently, leading to simpler representation possible and less cognitive load.
Before
After
To be noted I'm not entirely sure keeping this
RapierTransformPropagateSetis necessary, as a user might eventually want to order systems after systems, and there's no ambiguous beginning or end to this set.Further improvements (out of scope)
Split RapierContext
There are systems running sequentially, but each write to different parts of
RapierContext.If we split
RapierContext's:We'd be able to parallelize some systems execution.