Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #64: failed build against newer libmicrohttpd versions #65

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hadret
Copy link

@hadret hadret commented Oct 8, 2021

This MR fixes broken builds against newer libmicrohttpd versions while remaining compatible with the older ones. The change was introduced back in April last year by the upstream:

Wed 08 Apr 2020 10:53:01 PM CEST
Introduce enum MHD_Result for #MHD_YES/#MHD_NO to avoid using 'int' so much.
Note that this change WILL cause compiler warnings until (most) MHD callbacks
in application code change their return type from 'int' to 'enum MHD_Result'.
That said, avoiding possible confusions of different enums is going to make
the code more robust in the future. For conditional compilation, test
for "MHD_VERSION >= 0x00097002". -CG

And here's the relevant commit: https://git.gnunet.org/libmicrohttpd.git/commit/?id=6347f514aa2388e774d5bf356df8046864e5f73c

Many thanks to @janv37 for hunting this one down 🙌🏻

@hadret hadret requested a review from a team as a code owner October 8, 2021 12:50
Copy link

@kzangeli kzangeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Will this simple fix ever be merged?

@wferi
Copy link

wferi commented Apr 3, 2023

Ugh, I didn't notice this PR and submitted #79 myself, which also handles the same problem.
Unfortunately is doesn't seem likely that either would be merged anytime soon. :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants