Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apps: Set default apps dev build image to CNBBuilderImage_Heroku22. #1476

Merged
merged 2 commits into from
Dec 20, 2023
Merged

apps: Set default apps dev build image to CNBBuilderImage_Heroku22. #1476

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4396dbf
Set default apps dev build image to CNBBuilderImage_Heroku22
ElanHasson Dec 19, 2023
6952422
Make 18 the default
ElanHasson Dec 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions internal/apps/builder/cnb.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,10 +380,10 @@ func (b *CNBComponentBuilder) builderImage() string {
return b.builderImageOverride
}
for _, f := range b.spec.Features {
if strings.EqualFold(f, "buildpack-stack=ubuntu-22") {
return CNBBuilderImage_Heroku22
if strings.EqualFold(f, "buildpack-stack=ubuntu-18") {
return CNBBuilderImage_Heroku18
}
}

return CNBBuilderImage_Heroku18
return CNBBuilderImage_Heroku22
}