Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APP-Platform: Update CNB builder image #1462

Merged
merged 3 commits into from
Nov 21, 2023
Merged

APP-Platform: Update CNB builder image #1462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
694c09c
APPS-7962/Update CNB builder image
ShivaniKumar1 Nov 17, 2023
9b3cc57
Merge branch 'main' into APPS-7962/update-cnb-image
ShivaniKumar1 Nov 17, 2023
74539bd
Merge branch 'main' into APPS-7962/update-cnb-image
ShivaniKumar1 Nov 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions commands/apps_dev.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,8 +516,8 @@ func appDevPrepareEnvironment(ctx context.Context, ws *workspace.AppDev, cli bui
}

// TODO: get stack run image from builder image md after we pull it, see below
images = append(images, "digitaloceanapps/apps-run:heroku-18_1b6264d")
images = append(images, "digitaloceanapps/apps-run:heroku-22_1b6264d")
images = append(images, "digitaloceanapps/apps-run:heroku-18_db5978a")
images = append(images, "digitaloceanapps/apps-run:heroku-22_db5978a")
}

if componentSpec.GetType() == godo.AppComponentTypeStaticSite {
Expand Down
4 changes: 2 additions & 2 deletions internal/apps/builder/cnb.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ import (

const (
// CNBBuilderImage represents the local cnb builder.
CNBBuilderImage_Heroku18 = "digitaloceanapps/cnb-local-builder:heroku-18_63b9615"
CNBBuilderImage_Heroku22 = "digitaloceanapps/cnb-local-builder:heroku-22_63b9615"
CNBBuilderImage_Heroku18 = "digitaloceanapps/cnb-local-builder:heroku-18_da24158"
CNBBuilderImage_Heroku22 = "digitaloceanapps/cnb-local-builder:heroku-22_da24158"

appVarAllowListKey = "APP_VARS"
appVarPrefix = "APP_VAR_"
Expand Down