Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alerts: Expand on Monitoring Alerts Doc #1429

Merged
merged 3 commits into from
Oct 6, 2023
Merged

Alerts: Expand on Monitoring Alerts Doc #1429

merged 3 commits into from
Oct 6, 2023

Conversation

danaelhe
Copy link
Member

@danaelhe danaelhe commented Oct 5, 2023

Expanding on doctl monitoring alert -h docs to mitigate confusion between doctl monitoring alert and doctl monitoring uptime alert

@danaelhe danaelhe requested a review from a team October 5, 2023 18:55
mikeberezowski
mikeberezowski approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@mikeberezowski mikeberezowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch for clarification. Approved. 👍

@danaelhe danaelhe merged commit d082b6c into main Oct 6, 2023
6 checks passed
@danaelhe danaelhe deleted the alerts_doc branch October 6, 2023 17:39
@MrCuPper
Copy link

MrCuPper commented Oct 9, 2023

Thanks for solve this case

@MrCuPper
Copy link

MrCuPper commented Oct 9, 2023

Good catch for clarification. Approved. 👍

Congratulations 🫶

MrCuPper
MrCuPper reviewed Oct 9, 2023
View reviewed changes
Copy link

@MrCuPper MrCuPper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what you doing about it but it's just resolved with your code, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrCuPper MrCuPper MrCuPper left review comments

@mikeberezowski mikeberezowski mikeberezowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danaelhe @MrCuPper @mikeberezowski