Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing closing response body #1428

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Add missing closing response body #1428

merged 2 commits into from
Oct 4, 2023

Conversation

alexandear
Copy link
Contributor

@alexandear alexandear commented Oct 4, 2023 •
edited
Loading

This PR fixes possible resource leaks by adding a statement that closes a response body.

From the documentation:

The caller must close the response body when finished with it

Also, see this article for a deep dive into the problem.

andrewsomething
andrewsomething approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for another great fix!

@andrewsomething andrewsomething merged commit f7d07b3 into digitalocean:main Oct 4, 2023
6 checks passed
@alexandear alexandear deleted the do-missing-body-close branch October 4, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsomething andrewsomething andrewsomething approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexandear @andrewsomething