Skip to content

Commit

Permalink
remove unclean_leader_election_enable
Browse files Browse the repository at this point in the history
  • Loading branch information
dweinshenker committed Nov 14, 2023
1 parent a7f163a commit 354049a
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 15 deletions.
2 changes: 0 additions & 2 deletions args.go
Original file line number Diff line number Diff line change
Expand Up @@ -435,8 +435,6 @@ const (
ArgDatabaseTopicSegmentJitterMS = "segment-jitter-ms"
// ArgDatabaseTopicSegmentMS is the period of time, in ms, after which the log will be forced to roll if the segment file isn't full
ArgDatabaseTopicSegmentMS = "segment-ms"
// ArgDatabaseTopicUncleanLeaderElectionEnable determines whether to allow replicas that are not insync to be elected as leaders as last resort
ArgDatabaseTopicUncleanLeaderElectionEnable = "unclean-leader-election-enable"

// ArgPrivateNetworkUUID is the flag for VPC UUID
ArgPrivateNetworkUUID = "private-network-uuid"
Expand Down
7 changes: 0 additions & 7 deletions commands/databases.go
Original file line number Diff line number Diff line change
Expand Up @@ -1806,10 +1806,6 @@ func getDatabaseTopicConfigArgs(c *CmdConfig) *godo.TopicConfig {
res.SegmentMS = &i
}
}
bVal, err = c.Doit.GetBoolPtr(c.NS, doctl.ArgDatabaseTopicUncleanLeaderElectionEnable)
if err == nil && bVal != nil {
res.UncleanLeaderElectionEnable = bVal
}

return res
}
Expand Down Expand Up @@ -1905,9 +1901,6 @@ This command lists the following details for each partition of a given topic in
"Specifies the maximum time (in ms) for random jitter that is subtracted from the scheduled segment roll time to avoid thundering herd problems")
AddStringFlag(c, doctl.ArgDatabaseTopicSegmentMS, "", "",
"Specifies the maximum time (in ms) to wait to force a log roll if the segment file isn't full. After this period, the log will be forced to roll")
AddBoolFlag(c, doctl.ArgDatabaseTopicUncleanLeaderElectionEnable, "", false,
"Specifies whether to allow replicas that are not insync to be elected as leader as a last resort. This may result in data loss since those leaders are not in sync")
}
return cmd
}

Expand Down
6 changes: 0 additions & 6 deletions commands/displayers/database.go
Original file line number Diff line number Diff line change
Expand Up @@ -963,12 +963,6 @@ func (dt *DatabaseKafkaTopic) KV() []map[string]interface{} {
"value": *t.Config.SegmentMS,
})
}
if t.Config.UncleanLeaderElectionEnable != nil {
cfg = append(cfg, map[string]interface{}{
"key": "UncleanLeaderElectionEnable",
"value": *t.Config.UncleanLeaderElectionEnable,
})
}
o = append(o, cfg...)
}

Expand Down

0 comments on commit 354049a

Please sign in to comment.