Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Date-, File-Detection, etc. #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Updated Date-, File-Detection, etc. #39

wants to merge 1 commit into from

Conversation

matze-berg
Copy link

No description provided.

@matze-berg
Copy link
Author

Loved your work. PHP-Ref is really good in some points. But still sucks with Date & File detection. So many dumps will mark a String as Date or File, or a File as String. I have changed this, send you a request and there is nothing. You still have the wrong detection. So i think i will create a own one or switch to kint or krumo.
But thanks for your good work.

@ghost
Copy link

ghost commented Mar 23, 2017

php-ref beats them all

@jcmarchi
Copy link
Contributor

Based on what I've seen, seems like you decided to adjust the code style and add many "{" and "}", indentations and line spacing commonly only required for code readability. Not that it is wrong - when it is your code - but in terms of Git, it will cause flags to pretty much everything, resulting in changed or added/removed lines that are in fact the same. As a result, it is now virtually impossible to detect the actually changes you are proposing in the original code...

Maybe you would like to consider modifying only the pieces that actually make sense for your changes to be reviewed, leaving the rest unaltered? Just my two cents.

I'd love to try your proposed changes myself, but I am not much fond of replacing the entire file.

Thanks for the effort, BTW. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants