Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cancel button color to have ghost button style #3248

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

lunars97
Copy link
Contributor

@lunars97 lunars97 commented Nov 28, 2024

Short description

Right now cancel button in machine translation overlay has a red button instead of having ghost button. Additionally fix all other occurrences of cancel button not having the ghost button style.

Proposed changes

  • Change the button style to ghost button

Side effects

  • none

Resolved issues

Fixes: #2966


Pull Request Review Guidelines

Copy link
Member

@david-venhoff david-venhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

I found a few other cancel buttons that currently use different styles. Do you know whether those should also be changed?

  • Generic confirmation dialog:
    image

  • Link list row replace url:
    image

  • Poi map selector:
    image

@lunars97
Copy link
Contributor Author

Thanks, LGTM!

I found a few other cancel buttons that currently use different styles. Do you know whether those should also be changed?

  • Generic confirmation dialog:
    image
  • Link list row replace url:
    image
  • Poi map selector:
    image

Thank you for your review :) And the answer for your question is yes. I think they also definitely should be changed to be consistent with the styling

@lunars97 lunars97 changed the title Fix cancel button color in MT overlay Fix cancel button color to have ghost button style Nov 29, 2024
Copy link
Contributor

@JoeyStk JoeyStk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! :)

@lunars97 lunars97 merged commit e0c5a87 into develop Dec 2, 2024
5 checks passed
@lunars97 lunars97 deleted the bug/fix-cancel-button-color branch December 2, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change styling of "Cancel"-Button in MT overlay
3 participants