Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove checkbox appearence for roles who do not have edit permission in events and locations #3246

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Remove checkbox appearence for roles who do not have edit permission in events and locations #3246

wants to merge 1 commit into from
+20 −12

Conversation

lunars97
Copy link
Contributor

Short description

Checkboxes on list views for location and events are being shown for observer who has no edit permission.

Proposed changes

  • Add permission check conditions on these list views

Side effects

  • none

Resolved issues

Fixes: #3014

Pull Request Review Guidelines

david-venhoff
david-venhoff requested changes Nov 27, 2024
View reviewed changes
Copy link
Member

@david-venhoff david-venhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks mostly good to me.

Unfortunately, the paddings get messed up a little if the bulk action column is not included:
image

integreat_cms/cms/templates/events/event_list.html Outdated Show resolved Hide resolved
integreat_cms/cms/templates/events/event_list_row.html Outdated Show resolved Hide resolved
integreat_cms/cms/templates/pois/poi_list.html Outdated Show resolved Hide resolved
integreat_cms/cms/templates/pois/poi_list_row.html Outdated Show resolved Hide resolved
@lunars97 lunars97 force-pushed the bug/fix-checkbox-appearence-for-non-edit-permitted branch from d048da7 to 89ee7f9 Compare November 27, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-venhoff david-venhoff david-venhoff requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Checkbox for list views shown to users who don't have edit permission
2 participants
@lunars97 @david-venhoff