Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revive export box of statistics #3221

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Revive export box of statistics #3221

merged 2 commits into from
Nov 19, 2024

Conversation

MizukiTemma
Copy link
Member

Short description

This PR revives the export option box of the statistics that was accidentally removed.

Proposed changes

Side effects

  • should be none.

Resolved issues

Fixes: #3214

Pull Request Review Guidelines

@MizukiTemma MizukiTemma added the blocks-release This issue blocks a release label Nov 18, 2024
JoeyStk
JoeyStk approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@JoeyStk JoeyStk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the PR and for the speedy fix.
Since I only have one suggestion to which I'm open either way, I'm going to approve this already :)

integreat_cms/release_notes/current/unreleased/3131.yml Show resolved Hide resolved
integreat_cms/cms/templates/statistics/statistics_sidebar.html Show resolved Hide resolved
@MizukiTemma MizukiTemma mentioned this pull request Nov 19, 2024
Open
@MizukiTemma
Copy link
Member Author

MizukiTemma commented Nov 19, 2024 •
edited
Loading

I have noticed that the title "Statistics" is missing too, and it is revived in the second commit.

The design (v3) does not include the title, but it was an accident I guess? @nikolahoff @hauf-toni

This is what we see in the test server:
Screenshot 2024-11-19 133710

And this is in the prod server:
Screenshot 2024-11-19 133638

@MizukiTemma MizukiTemma merged commit 092dd2f into develop Nov 19, 2024
5 checks passed
@MizukiTemma MizukiTemma deleted the bug/statistics_export_box branch November 19, 2024 14:19
@nikolahoff
Copy link

@MizukiTemma i think it was. @hauf-toni made the design. I think you should add the HL "statistics" there. I will change the design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-venhoff david-venhoff david-venhoff approved these changes

@JoeyStk JoeyStk JoeyStk approved these changes

@charludo charludo Awaiting requested review from charludo

@lunars97 lunars97 Awaiting requested review from lunars97

@jarlhengstmengel jarlhengstmengel Awaiting requested review from jarlhengstmengel

Assignees
No one assigned
Labels
blocks-release This issue blocks a release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Export option in statistics page is missing
4 participants
@MizukiTemma @nikolahoff @JoeyStk @david-venhoff