Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor (fix) Compilations & Featured In #100

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

NeatoMonster
Copy link

Behavior before:

  • By default, grab everything where ARTIST == ALBUM ARTIST, ignoring TYPE 2 COMPILATIONS but including TYPE 1 & TYPE 3 isCompilation releases.
  • "include_featured_in": true by itself did nothing; it was unchecked.
  • "include_unofficial": false is ignored once "include_compilations": true is enabled.
  • "include_compilations": true by itself grabbed TYPE 2 releases, as well as TYPE 0 & TYPE 3 FEATURED IN releases.
  • "include_compilations": true + "include_featured_in": true together grabbed the above as well as TYPE 1 FEATURED IN releases and TYPE 1 & TYPE 3 COMPILATIONS (isCompilation) releases.

Behavior now:

  • By default, grab everything where ARTIST == ALBUM ARTIST, including TYPE 2 and TYPE 1 & TYPE 3 isCompilation.
  • "include_unofficial": false is always adhered to.
  • "include_compilations": true removes the check for ARTIST == ALBUM ARTIST in compilation releases.
  • "include_featured_in": true removes the check for ARTIST == ALBUM ARTIST in non-compilation releases.

Notes:

  • Most TYPE 1 compilations are things like "TOP HITS 20XX" or "10'S ROCK" and while most of them are marked isCompilation, not all of them are.
  • Two config options that may be useful to implement in the future would be filtering ARTIST == ALBUM ARTIST compilations (include_self_compilations), and TYPE 2 vs isCompilation filtering (unsure how these releases are meant to differ.)

Previous behavior was very broken.
Stay more in-line with previous behavior and documentation.
@digitalec
Copy link
Owner

Thanks for the PR and apologies for the delay in reviewing. I will test this locally to see what additional releases are detected against my existing database.

@digitalec digitalec self-assigned this Apr 5, 2024
@digitalec digitalec added the bug Something isn't working label Apr 5, 2024
@digitalec digitalec added this to the 2.22 milestone Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants