Refactor (fix) Compilations & Featured In #100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Behavior before:
isCompilation
releases."include_featured_in": true
by itself did nothing; it was unchecked."include_unofficial": false
is ignored once"include_compilations": true
is enabled."include_compilations": true
by itself grabbed TYPE 2 releases, as well as TYPE 0 & TYPE 3 FEATURED IN releases."include_compilations": true
+"include_featured_in": true
together grabbed the above as well as TYPE 1 FEATURED IN releases and TYPE 1 & TYPE 3 COMPILATIONS (isCompilation
) releases.Behavior now:
isCompilation
."include_unofficial": false
is always adhered to."include_compilations": true
removes the check for ARTIST == ALBUM ARTIST in compilation releases."include_featured_in": true
removes the check for ARTIST == ALBUM ARTIST in non-compilation releases.Notes:
isCompilation
, not all of them are.include_self_compilations
), and TYPE 2 vsisCompilation
filtering (unsure how these releases are meant to differ.)