Add type table loader. #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added
- Add `async function typeTableLoader({registryEntryId})` option to look
up the `typeTable` to use by id for both `encode` and `decode`.
Changed
- Refactor `registryEntryId` encoding and decoding logic. Trying to be
more readable and handle more error and edge cases. This is a work in
progress.
- Update actions. - Enable codecov uploading.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #98 +/- ##
==========================================
+ Coverage 88.19% 91.55% +3.36%
==========================================
Files 30 34 +4
Lines 1881 2559 +678
==========================================
+ Hits 1659 2343 +684
+ Misses 222 216 -6
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
dlongley
approved these changes
Oct 21, 2024
- Fix lint issue. - Sync types between files. - Improve optional options marking.
- Fail if both typeTable and typeTableLoader are specified. - Add tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.