Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade dependencies #159

Merged
merged 2 commits into from
Nov 19, 2024
Merged

upgrade dependencies #159

merged 2 commits into from
Nov 19, 2024

Conversation

johnykei
Copy link
Collaborator

@johnykei johnykei commented Nov 19, 2024

@digital-go-jp/design-system

依存パッケージのアップグレードをしました。

style-dictionary の 4.2.0 へのアップグレードは、Prettier 絡みのエラーでビルドができない問題がありそのままにしています。
style-dictionary にIssue も出したので、これが解決したらアップグレードします。

確認方法

以下のコマンドがすべて正常に動作すること

  • npm run format
  • npm run lint
  • npm run type:check
  • npm run transform-figma-tokens
  • npm run build

@johnykei johnykei requested a review from a team as a code owner November 19, 2024 05:51
@johnykei johnykei requested a review from tsmd November 19, 2024 05:51
@johnykei
Copy link
Collaborator Author

動作問題なさそうなのでセルフマージします。

@johnykei johnykei merged commit a5ba593 into develop Nov 19, 2024
2 checks passed
@johnykei johnykei deleted the feature/upgrade-dependencies branch November 19, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant