Minor addition #50
Open
Minor addition #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng utils connectivity matrix. Added new filled sphere method to geometry sphere, and exposed it in buried volume.
kjelljorner
reviewed
Jun 18, 2023
| @@ -393,6 +402,7 @@ def compute_distal_volume( | |||
| center=self._sphere.center, | |||
| radius=new_radius, | |||
| density=self._sphere.density, | |||
| method=self._method, | |||
There was a problem hiding this comment.
I think it's more consistent to use the same method as when creating the BuriedVolume object?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few minor additions to some core functionalities. Some of them are fully debatable and arguably none of them are really needed whatsoever. Nevertheless, they should not break any backwards compatibility and, if anything, should improve things a tad.
sasa.pyusing the aforementioned function with a boolean call. This leads to a negligible speedup due to the bottleneck being in the grid point distance evaluation, but gets rid of a TODO and is, indeed, slightly faster."sobol"to generate exclusively filled sphere points. This method is based on pseudorandom number generation using Sobol sequences. It is thus not very suitable as a default due to lack of reproducibility (the random seed could be fixed to deal with this). However, it gives approximately the same accuracy with significantly less grid points (~half the density). In the very low density regime, it is significantly more accurate. This may come in handy whenever very large spheres are to be used. Therefore, I think its nice to have as a backup.buried_volume.pyclass. Set projection as default throughout. Added it totest_buried_volume.pyas well.