Update to @iiif/helpers from Vault + new Atlas version.
#237
Conversation
❌ Deploy Preview for iiif-canvas-panel failed.
|
❌ Deploy Preview for iiif-canvas-panel-demos failed.
|
✅ Deploy Preview for canvas-panel-storybook canceled.
|
| import externalStylesheet from '@site/sandboxes/external-stylesheet.csb/\_load'; | ||
| import opacity from '@site/sandboxes/20-styling/opacity.csb/\_load'; import | ||
| opacity2 from '@site/sandboxes/20-styling/opacity2.csb/\_load'; import flexbox | ||
| from '@site/sandboxes/01-show-canvas/flexbox.csb/\_load'; import { Sandbox } | ||
| from '@site/Sandbox'; | ||
|
|
There was a problem hiding this comment.
TODO: fix. Looks like the automatic linting wrecked this (and a few more)
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ce917ef:
|
| <canvas-panel | ||
| iiif-content="http://example.org/canvas-1.json" | ||
| choice-id="http://example.org/choice-set-a/3, http://example.org/choice-set-b/7#opacity=0.5" | ||
| /> Useful for static rendering -----^ | ||
| <canvas-panel | ||
| iiif-content="http://example.org/canvas-1.json" | ||
| choice-id="http://example.org/choice-set-a/3, http://example.org/choice-set-b/7#opacity=0.5" | ||
| /> | ||
| Useful for static rendering -----^ |
docusaurus.config.js
Outdated
| // 'https://cdn.jsdelivr.net/npm/@digirati/canvas-panel-web-components@latest', | ||
| "https://cdn.jsdelivr.net/npm/@digirati/[email protected]", | ||
| // "https://cdn.jsdelivr.net/npm/@digirati/[email protected]", | ||
| // 'https://cdn.jsdelivr.net/npm/@iiif/vault-helpers@latest/dist/index.umd.js' | ||
| ], | ||
| // clientModules: [ | ||
| // require.resolve('./packages/canvas-panel/dist/bundle.js'), | ||
| // ], | ||
| clientModules: [require.resolve("./packages/canvas-panel/dist/bundle.js")], |
|
@abrin I'm almost finished this refactor, which includes a better build system. I've published a temporary package, which has the new code (most recent main was merged in too). Would it be possible for you to test this package and let me know if it continue to work as expected with your build tooling? The updates and compatibility are worth the update (in my opinion). |
|
@stephenwf will do. @danieltbrennan is in the image viewer today and will give it a spin |
|
@stephenwf testing this and was able to build in our component without any problems at that step. So far though noticing an issue where the behavior of paged manifests as loaded with sequence-panel seems to have changed, notably that the first standalone page is being included again within the first pair of open pages. See below from our storybook:
Will test more but this is the first thing that caught my eye when running through our Storybook. Some fixtures for that type of manifest if useful: https://data.getty.edu/media/manifest/bayard-custom (prezi v3) |
|
Oh that is strange. I'll double check the changes. It does seem to be working in another viewer that uses the same sequence calculations, it must be a key or cache somewhere. I'll have a look into it! Great news about the build changes though! That will hopefully make this a smooth transition, and much easier to iterate I hope. |
Summary of changes:
@iiif/vault->@iiif/helpers@iiif/vault-helpers->@iiif/helpers@atlas-viewer/atlasbumped to v2.x (currently a PR branch)@iiif/parserbumped to v2.x@iiif/presentation-3bumped to v2.xreact-iiif-vaultbumped to v1.xIn practice this will mean a few updates to the sandboxes.
Is now:
Or just:
A lot of changes under the hood, but no changes to the API. (Vault, React IIIF Vault or Helpers)