Merge pull request #82 from digipost/b_Identification_v2

Bug: fixes the IdentificationValue as string causing nullpointer Aleksander-OK
digipost · Oct 22, 2015 · 57ab8e0 · 57ab8e0
2 parents 8b4a943 + d6edc71
commit 57ab8e0
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/Digipost.Api.Client.Domain/Utilities/DataTransferObjectConverter.cs b/Digipost.Api.Client.Domain/Utilities/DataTransferObjectConverter.cs
@@ -281,7 +281,7 @@ public static IIdentificationResult FromDataTransferObject(IdentificationResultD
             }
             else
             {
-                identificationResult = new IdentificationResult(identificationResultDto.IdentificationResultType, identificationResultDto.IdentificationValue as string);
+                identificationResult = new IdentificationResult(identificationResultDto.IdentificationResultType, identificationResultDto.IdentificationValue.ToString());
             }
 
             return identificationResult;

diff --git a/Digipost.Api.Client.Tests/Unittest/DtoTests/DataTransferObjectConverterTests.cs b/Digipost.Api.Client.Tests/Unittest/DtoTests/DataTransferObjectConverterTests.cs
@@ -489,15 +489,15 @@ public void IdentificationByPinReturnsUnidentifiedResultWithUnidentifiedReason()
             public void IdentificationByPinReturnsInvalidResultWithInvalidReason()
             {
                 //Arrange
-                const string invalidValue = "InvalidPersonalIdentificationNumber";
+                object invalidValue = InvalidReason.InvalidPersonalIdentificationNumber;
                 IdentificationResultDataTransferObject source = new IdentificationResultDataTransferObject
                 {
                     IdentificationResultCode = IdentificationResultCode.Invalid,
                     IdentificationValue = invalidValue,
                     IdentificationResultType = IdentificationResultType.InvalidReason
                 };
 
-                IdentificationResult expected = new IdentificationResult(IdentificationResultType.InvalidReason, invalidValue);
+                IdentificationResult expected = new IdentificationResult(IdentificationResultType.InvalidReason, invalidValue.ToString());
 
                 //Act
                 var actual = DataTransferObjectConverter.FromDataTransferObject(source);
@@ -562,15 +562,15 @@ public void IdentificationByAddressReturnsIdentifiedResultWithPersonalAliasResul
             public void IdentificationByAddressReturnsUnidentifiedResultWithUnidentifiedReason()
             {
                 //Arrange
-                var reason = "NotFound";
+                var reason = UnidentifiedReason.NotFound;
                 IdentificationResultDataTransferObject source = new IdentificationResultDataTransferObject
                 {
                     IdentificationResultCode = IdentificationResultCode.Unidentified,
                     IdentificationValue = reason,
                     IdentificationResultType = IdentificationResultType.UnidentifiedReason
                 };
 
-                IdentificationResult expected = new IdentificationResult(IdentificationResultType.UnidentifiedReason, reason);
+                IdentificationResult expected = new IdentificationResult(IdentificationResultType.UnidentifiedReason, reason.ToString());
 
                 //Act
                 var actual = DataTransferObjectConverter.FromDataTransferObject(source);
@@ -625,15 +625,15 @@ public void IdentificationByOrganizationNumberReturnsIdentifiedResultWithPersonA
             public void IdentificationByOrganizationNumberReturnsUnidentifiedResultWithUnidentifiedReason()
             {
                 //Arrange
-                var reason = "NotFound";
+                var reason = UnidentifiedReason.NotFound;
                 IdentificationResultDataTransferObject source = new IdentificationResultDataTransferObject
                 {
                     IdentificationResultCode = IdentificationResultCode.Unidentified,
                     IdentificationValue = reason,
                     IdentificationResultType = IdentificationResultType.UnidentifiedReason
                 };
 
-                IdentificationResult expected = new IdentificationResult(IdentificationResultType.UnidentifiedReason, reason);
+                IdentificationResult expected = new IdentificationResult(IdentificationResultType.UnidentifiedReason, reason.ToString());
 
                 //Act
                 var actual = DataTransferObjectConverter.FromDataTransferObject(source);
@@ -648,15 +648,15 @@ public void IdentificationByOrganizationNumberReturnsUnidentifiedResultWithUnide
             public void IdentificationByOrganizationNumberReturnsInvalidResultWithInvalidReason()
             {
                 //Arrange
-                const string invalidValue = "InvalidOrganisationNumber";
+                object invalidValue = InvalidReason.InvalidOrganisationNumber;
                 IdentificationResultDataTransferObject source = new IdentificationResultDataTransferObject
                 {
                     IdentificationResultCode = IdentificationResultCode.Invalid,
                     IdentificationValue = invalidValue,
                     IdentificationResultType = IdentificationResultType.InvalidReason
                 };
 
-                IdentificationResult expected = new IdentificationResult(IdentificationResultType.InvalidReason, invalidValue);
+                IdentificationResult expected = new IdentificationResult(IdentificationResultType.InvalidReason, invalidValue.ToString());
 
                 //Act
                 var actual = DataTransferObjectConverter.FromDataTransferObject(source);
-Original file line number
+Diff line change
@@ Expand Up @@
                 }
                 else
                 {
-                    identificationResult = new IdentificationResult(identificationResultDto.IdentificationResultType, identificationResultDto.IdentificationValue as string);
+                    identificationResult = new IdentificationResult(identificationResultDto.IdentificationResultType, identificationResultDto.IdentificationValue.ToString());
                 }
                 return identificationResult;
@@ Expand Down @@